Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty LDAP search result from deactivating all users (#9879) #9896

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jan 20, 2020

Backport #9879

  • Add option to prevent LDAP from deactivating everything on empty search

  • Update options/locale/locale_en-US.ini

Co-Authored-By: guillep2k 18600385+guillep2k@users.noreply.github.com

Co-authored-by: guillep2k 18600385+guillep2k@users.noreply.github.com
Co-authored-by: Lunny Xiao xiaolunwen@gmail.com

…ch (go-gitea#9879)

* Add option to prevent LDAP from deactivating everything on empty search

* Update options/locale/locale_en-US.ini

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath added type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jan 20, 2020
@zeripath zeripath added this to the 1.11.0 milestone Jan 20, 2020
@zeripath zeripath changed the title Prevent empty LDAP search result from deactivating everyone ( Prevent empty LDAP search result from deactivating everyone (#9879) Jan 20, 2020
@zeripath zeripath changed the title Prevent empty LDAP search result from deactivating everyone (#9879) Prevent empty LDAP search result from deactivating all users (#9879) Jan 20, 2020
@zeripath
Copy link
Contributor Author

I don't know what the cause of this issue is but it's highly irritating for users. I don't know where the bug is - if it's even in Gitea - but there must be a bug somewhere.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 20, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2020
@lafriks lafriks merged commit ff508c9 into go-gitea:release/v1.11 Jan 20, 2020
@zeripath zeripath deleted the backport-9890 branch January 20, 2020 19:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants