Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch #9927

lunny · 2020-01-22T03:41:53Z

only load head information when head repository/branch valid.
close all branch related unmerged pull requests when the branch deleted
close all repository related unmerged pull requests when repo deleted
broken pull requests tests

codecov-io · 2020-01-22T04:53:30Z

Codecov Report

❗ No coverage uploaded for pull request base (master@29e5a90). Click here to learn what that means.
The diff coverage is 51.69%.

@@            Coverage Diff            @@
##             master    #9927   +/-   ##
=========================================
  Coverage          ?   42.26%           
=========================================
  Files             ?      610           
  Lines             ?    80364           
  Branches          ?        0           
=========================================
  Hits              ?    33969           
  Misses            ?    42217           
  Partials          ?     4178

Impacted Files	Coverage Δ
models/models.go	`61.71% <ø> (ø)`
models/repo_list.go	`76.81% <ø> (ø)`
models/issue.go	`55.28% <ø> (ø)`
routers/api/v1/org/hook.go	`0% <0%> (ø)`
cmd/admin.go	`0% <0%> (ø)`
routers/org/teams.go	`0% <0%> (ø)`
models/pull_sign.go	`34.86% <0%> (ø)`
routers/api/v1/repo/issue_subscription.go	`0% <0%> (ø)`
routers/api/v1/repo/release.go	`46.2% <0%> (ø)`
routers/api/v1/repo/key.go	`20.37% <0%> (ø)`
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e5a90...7982aca. Read the comment docs.

lunny · 2020-01-22T06:29:52Z

It's ready to review now.

models/pull.go

modules/repofiles/update.go

models/pull.go

modules/repofiles/update.go

lunny · 2020-01-22T15:44:24Z

@guillep2k @zeripath done.

services/pull/pull.go

…lated pull requests when delete branch

lunny · 2020-01-23T03:20:19Z

@guillep2k done.

guillep2k

LGTM

…lated pull requests when delete head repository or head branch (go-gitea#9927) * fix pull view when head repository or head branch missed and close related pull requests when delete branch * fix pull view broken when head repository deleted * close pull requests when head repositories deleted * Add tests for broken pull request head repository or branch * fix typo * ignore special error when close pull request Co-authored-by: Lauris BH <lauris@nix.lv>

lunny · 2020-01-25T03:49:54Z

also fix #2466

…lated pull requests when delete head repository or head branch (#9927) (#9974) * fix pull view when head repository or head branch missed and close related pull requests when delete branch * fix pull view broken when head repository deleted * close pull requests when head repositories deleted * Add tests for broken pull request head repository or branch * fix typo * ignore special error when close pull request Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv>

lunny added the type/bug label Jan 22, 2020

lunny added this to the 1.12.0 milestone Jan 22, 2020

lunny added the pr/wip This PR is not ready for review label Jan 22, 2020

lunny force-pushed the lunny/fix_pr_broken branch from 3f2c159 to 41292b8 Compare January 22, 2020 04:17

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2020

lunny removed the pr/wip This PR is not ready for review label Jan 22, 2020

lunny changed the title ~~fix pull view when head repository or head branch missed and close related pull requests when delete branch~~ Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch Jan 22, 2020

guillep2k reviewed Jan 22, 2020

View reviewed changes

models/pull.go Outdated Show resolved Hide resolved

modules/repofiles/update.go Show resolved Hide resolved

modules/repofiles/update.go Outdated Show resolved Hide resolved

zeripath reviewed Jan 22, 2020

View reviewed changes

models/pull.go Outdated Show resolved Hide resolved

modules/repofiles/update.go Show resolved Hide resolved

modules/repofiles/update.go Show resolved Hide resolved

lunny force-pushed the lunny/fix_pr_broken branch from 7c834c3 to 3b822df Compare January 22, 2020 15:43

guillep2k reviewed Jan 22, 2020

View reviewed changes

services/pull/pull.go Outdated Show resolved Hide resolved

services/pull/pull.go Show resolved Hide resolved

services/pull/pull.go Show resolved Hide resolved

lunny added 6 commits January 23, 2020 11:19

fix pull view when head repository or head branch missed and close re…

2f548d3

…lated pull requests when delete branch

fix pull view broken when head repository deleted

e804e14

close pull requests when head repositories deleted

8d4f90b

Add tests for broken pull request head repository or branch

98a5129

fix typo

be8b1c6

ignore special error when close pull request

74754bd

lunny force-pushed the lunny/fix_pr_broken branch from 3b822df to 74754bd Compare January 23, 2020 03:20

guillep2k approved these changes Jan 23, 2020

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 23, 2020

zeripath approved these changes Jan 23, 2020

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2020

Merge branch 'master' into lunny/fix_pr_broken

b5f6acf

lafriks approved these changes Jan 23, 2020

View reviewed changes

lafriks and others added 2 commits January 23, 2020 19:30

Merge branch 'master' into lunny/fix_pr_broken

29e5a90

Merge branch 'master' into lunny/fix_pr_broken

7982aca

lunny merged commit f2d12f7 into go-gitea:master Jan 25, 2020

lunny deleted the lunny/fix_pr_broken branch January 25, 2020 02:48

lunny mentioned this pull request Jan 25, 2020

Close related pull requests when deleting head repository or head branch (#9927) #9974

Merged

lunny mentioned this pull request Jan 25, 2020

When a pull request branch deleted, the opened pull request should be closed automatically #2466

Closed

lunny mentioned this pull request Mar 25, 2020

branch: Close all the associated PRs when a branch is deleted. #5646

Closed

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch #9927

Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch #9927

lunny commented Jan 22, 2020 •

edited

Loading

codecov-io commented Jan 22, 2020 •

edited

Loading

lunny commented Jan 22, 2020

lunny commented Jan 22, 2020

lunny commented Jan 23, 2020

guillep2k left a comment

lunny commented Jan 25, 2020

Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch #9927

Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch #9927

Conversation

lunny commented Jan 22, 2020 • edited Loading

codecov-io commented Jan 22, 2020 • edited Loading

Codecov Report

lunny commented Jan 22, 2020

lunny commented Jan 22, 2020

lunny commented Jan 23, 2020

guillep2k left a comment

Choose a reason for hiding this comment

lunny commented Jan 25, 2020

lunny commented Jan 22, 2020 •

edited

Loading

codecov-io commented Jan 22, 2020 •

edited

Loading