[Docs] Logging Configuration - Use logrotate Instead

[bagasme]

As @techknowlogick suggest on #9866, I added notes to Logging Configurations if logrotate is about to be used instead of built-in implementation.

When this PR is merged, it will be automatically close #9866.

[codecov-io]

Codecov Report

Merging #9930 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9930   +/-   ##
=======================================
  Coverage   42.26%   42.26%           
=======================================
  Files         608      608           
  Lines       79411    79411           
=======================================
  Hits        33566    33566           
  Misses      41702    41702           
  Partials     4143     4143

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871444f...9eee9d1. Read the comment docs.

[jolheiser]

Wording nits

[zeripath]

AFAIU this technique could still cause loss of logs.

If we genuinely want to support logrotate we will need some way of halting log output and then reopening it. That would need probably need tying into graceful as a currently unused signal (SIGUSR1 is free but there might be a better one) or by adding another command and private endpoint.

The only safe other options other than using our logging controls, are to use rotatelog from Apache by writing to a pipe or write logs to syslog through systemd

[bagasme]

@zeripath perhaps blocking this PR until halting log output implementation done?

[zeripath]

Yup that's what my request changes does. Unless others disagree and want this merged or the wording is changed to add a sufficient warning - it can't be merged.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@633f52c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #9930   +/-   ##
=========================================
  Coverage          ?   42.26%           
=========================================
  Files             ?      608           
  Lines             ?    79411           
  Branches          ?        0           
=========================================
  Hits              ?    33561           
  Misses            ?    41709           
  Partials          ?     4141           

Impacted Files	Coverage Δ
modules/repofiles/file.go	90.62% <0.00%> (ø)
modules/setting/log.go	69.36% <0.00%> (ø)
models/notification.go	64.13% <0.00%> (ø)
modules/util/sanitize.go	0.00% <0.00%> (ø)
routers/repo/view.go	38.59% <0.00%> (ø)
routers/api/v1/org/team.go	39.82% <0.00%> (ø)
modules/markup/markup.go	77.14% <0.00%> (ø)
modules/structs/user_app.go	0.00% <0.00%> (ø)
models/migrations/v37.go	0.00% <0.00%> (ø)
modules/log/event.go	64.61% <0.00%> (ø)
... and 598 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633f52c...afb7aef. Read the comment docs.

[zeripath]

Now #11777 has been merged we can finally move forward with this. I expect that the below wording is not the best but it is an example of the kind of thing we need to add.

[zeripath]

Hi @bagasme!

Looks like #11777 has been merged so we might finally be able to get this merged - see my suggestion.

[zeripath]

OK now we have merged my PR causing release and reopen, and updated this - I think we're good to go.

[techknowlogick]

🚀