-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Check For Existing Files And Attachments #97
Open
Gamma169
wants to merge
38
commits into
go-gomail:master
Choose a base branch
from
Gamma169:Fixing-Attachment-Error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ec61a8a
Added Check For Existing Files And Attachments
Gamma169 c331832
Updated Tests To Actually Create File
Gamma169 92faf95
Unfortunate fork ;-( Original maintainer missing/uncontactable
pedromorgan 3e55582
Fix imports
pedromorgan 594fad0
fix coverage link
pedromorgan f10eb0a
Export NetDialTimeout to public
Elbandi 8340910
Document NetDialTimeout
ivy ab8dca3
Merge pull request #4 from ivy/export-net-dial-timeout
pedromorgan 8dc4458
Add syntax highlighting to Go example
ivy c0dd687
Ditch go < 1.5 (and no external dependancies)
pedromorgan 4e2ebb0
make travis check master+v2 for now
pedromorgan 0fbc7e5
Merge pull request #5 from ivy/syntax-highlighting
pedromorgan 00ccffb
gitter
pedromorgan 875d2d5
revert removal < 1.5 and small fixes
pedromorgan 45ab546
Allow timeout in connections, retries to be configurable
connor4312 0fb8809
Document default Dialer.RetryFailure
ivy 73cb68f
Merge pull request #10 from ivy/user-defined-timeouts
ivy 8367efd
Remove gitter badge
ivy 1e5036a
Rename package to mail
ivy a691f04
Update readme with gopkg.in import path
ivy c6c7e1d
Fix import path in readme example
ivy 6a770e9
Fix references to old repo name
ivy 7c2224c
travis: Fix incorrectly specified Go versions
ivy 1f3725f
Fix missing import in mime_go14.go
ivy ef37398
Document progress and steps for transitioning
ivy 71893bb
Added teardown method for files
Gamma169 cd0ee12
Removed Rename File Creation
Gamma169 8a0aa62
Fixed Build Typo
Gamma169 8ca38ac
Added originalName property for file
Gamma169 c491950
Fixed Typo with originalName
Gamma169 09b474d
Added Tests for Embed/Attachment Validation
Gamma169 c117660
Fogot to add strings import
Gamma169 c273b3f
Merge branch 'v2' into Fixing-Attachment-Error
Gamma169 f5e292e
Removed first net/mail import
Gamma169 4a60beb
Revert "Fogot to add strings import"
Gamma169 aaa67cd
Revert A bunch of things
Gamma169 bafcd84
Revert "Removed first net/mail import"
Gamma169 3e277d0
Revert "Merge branch 'v2' into Fixing-Attachment-Error"
Gamma169 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but won't this also create a bunch of files in the working directory? We need a teardown function to remove them when the test suite finishes. Also, this ends up being a step away from an actual
copyFile
and not a mock.I need to think about this more. I'll come back after I've reviewed some of the other pull requests.