-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert check for incomplete parentheses #2674
Conversation
…t SQL injection." This reverts commit e3cc5ea.
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
==========================================
- Coverage 79.57% 79.49% -0.09%
==========================================
Files 24 24
Lines 3472 3458 -14
==========================================
- Hits 2763 2749 -14
Misses 609 609
Partials 100 100
Continue to review full report at Codecov.
|
Related issue: #2561 |
Thank you, sorry for the issue. |
@jinzhu are you going to provide a version with a fix for this CVE https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-15562 ? |
Hi @Jonathan34 It's hard to make this one correct, suggest you don't accept user's input as the select params. |
@Jonathan34 |
…o prevent SQL injection." (go-gorm#2674)" This reverts commit 81c17a7.
…ed parenthesis Revert "Revert "Fix go-gorm#2517 : Check for incomplete parentheses to prevent SQL injection." (go-gorm#2674)"
…t SQL injection." (go-gorm#2674) This reverts commit e3cc5ea.
…t SQL injection." (go-gorm#2674) This reverts commit c59ad19.
Make sure these boxes checked before submitting your pull request.
For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.
What did this pull request do?
This reverts commit e3cc5ea from https://github.com/jinzhu/gorm/pull/2519 due to breaking of valid queries.