Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tidb integration test cases #6014

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

Icemap
Copy link
Contributor

@Icemap Icemap commented Feb 1, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Add TiDB integration test cases. And skip some features that TiDB is not implicated.
This PR is based on go-gorm/mysql#105, need to wait for that to merge.

User Case Description

@Icemap
Copy link
Contributor Author

Icemap commented Feb 1, 2023

This PR request go-gorm/mysql#105 merged. Please hold until it's merged.

@Icemap
Copy link
Contributor Author

Icemap commented Feb 8, 2023

All tests passed. PTAL. @jinzhu

@jinzhu jinzhu merged commit 02b7e26 into go-gorm:master Feb 8, 2023
@jinzhu
Copy link
Member

jinzhu commented Feb 8, 2023

Maybe you can add how to connect tidb to the help document. https://github.com/go-gorm/gorm.io/blob/master/pages/docs/connecting_to_the_database.md

@Icemap
Copy link
Contributor Author

Icemap commented Feb 8, 2023

THX, I'll be working on it.

@Icemap
Copy link
Contributor Author

Icemap commented Feb 8, 2023

The document PR is: go-gorm/gorm.io#638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants