Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect index option param. #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

abbyssoul
Copy link

  • [X ] Do only one thing
  • [ X] Non breaking API changes
  • [ X] Tested

What did this pull request do?

When creating indexes, the option argument is taken into account.

User Case Description

When creating indexes, users might need greater control over the resulting DDL statement. For example, users need a way to specify "NULLS [ NOT ] DISTINCT" SQL option when working with Postgres as described here: https://www.postgresql.org/docs/current/sql-createindex.html
Despite documentation stating that option param is supported: https://gorm.io/docs/indexes.html, Postgres Mirgator implementation does not use it. Example of use opened issue that will be closed by this PR: go-gorm/gorm#6085

@abbyssoul
Copy link
Author

Hi @a631807682 ,
Thank you for approving this PR.
Unfortunately, I don't have write access to this repo. Would you or someone else with permissions, be able to merge it in plz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants