Issue #341: add Crate support

[inge4pres]

This PR introduces an additional dialect to support crate.io as per issues/341

[nelsam]

Apologies for the 6 month delay; this looks solid, I'm just going to try to make sure that it's tested in CI before merging

[inge4pres]

Hi :) no worries at all! Thank you for getting in touch

[notzippy]

Any updates on this ? I have an application in need of this as well :-D

[nelsam]

I'm working on it now; just need to figure out how to get travis to spin up a crate DB.

[nelsam]

This is incorrect. Crate uses double-quotes for fields and whatnot. It should be return `"` + f + `"` .

[nelsam]

I added crate to the tests and it has been failing in a few ways. The first was the quoted field problem, but even after solving that, it had failures.

I've pushed a commit to your fork that adds tests; can you work on getting the tests passing?

edit: FYI, I did not update the unit tests for the crate dialect, so they'll be failing because I changed the quote characters for QuoteField.

[inge4pres]

Hi @nelsam as this PR is 7 months old, I will reset my dev environment.
I tihnk I should also pull latest changes from master to consitently release the feature to add support for Crate.

From travis.yml I can see Crate is installed using the deprecated PPA installation: this forces use of 2.0.x, while a more recent version is available through adding repositories to have 2.1.x and higher, see install-cratedb-from-ppa-legacy and install-from-deb-repo.

[nelsam]

@inge4pres yeah, feel free to update the .travis.yml in whatever way is best. I have no experience with crate, I just pulled the PPA from the install script (https://install.crate.io).

There are currently no conflicts with master, but feel free to merge or rebase on top of master first and do what you need to.

[inge4pres]

I went as far as making pass the majority of tests, but at a certain point I'm facing that CrateDB has no INDEX statement available.

[nelsam]

It's fine to update the tests to skip testing index against crate. We've had to do similar things with one of the mysql drivers. See [here](https://github.com/go-gorp/gorp/blob/master/gorp_test.go#L738) for an example.

…

On Oct 30, 2017 07:50, "Francesco Gualazzi" ***@***.***> wrote: I went as far as making pass the majority of tests, but at a certain point I'm facing that CrateDB has no INDEX statement available. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#342 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-QBGvLWRgY7gPNjn6wrYdSDft5Ww1Eks5sxdQOgaJpZM4L9HYk> .

[aman00323]

Any update on this ?