Update documentation on named bind parameters. #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't able to find documentation of these in the godoc, so I added it. Also, the README had out-of-date information. It said named bind parameters were only supported for Select, but they are also supported for Exec since 2015 (04b2c71). The documentation for ExpandSlices was embedded in the DbMap type, which made it hard to read on godoc - the entire documentation was in one large `pre` block. I moved it up to the package level docs.
jsha
added a commit
to letsencrypt/borp
that referenced
this pull request
Jul 5, 2023
I wasn't able to find documentation of these in the godoc, so I added it. Also, the README had out-of-date information. It said named bind parameters were only supported for Select, but they are also supported for Exec since 2015 (04b2c71). The documentation for ExpandSlices was embedded in the DbMap type, which made it hard to read on godoc - the entire documentation was in one large `pre` block. I moved it up to the package level docs. Note: this is a recreation of go-gorp#421 Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to find documentation of these in the godoc, so I added
it. Also, the README had out-of-date information. It said named bind
parameters were only supported for Select, but they are also supported
for Exec since 2015 (04b2c71).
The documentation for ExpandSlices was embedded in the DbMap type, which
made it hard to read on godoc - the entire documentation was in one
large
preblock. I moved it up to the package level docs.