-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Description
The struct used by the remote load functionality uses 64 bit integers as strings.
With CH 25.8 those are no longer strings in json ClickHouse/ClickHouse#74079
graphite-clickhouse-1 | goroutine 182 [running]:
graphite-clickhouse-1 | github.com/lomik/graphite-clickhouse/helper/rollup.(*Rules).Lookup(0xff?, {0xc0004af800?, 0x2000000000000ff?}, 0xbc4a2c30?, 0x49?)
graphite-clickhouse-1 | /go/src/github.com/lomik/graphite-clickhouse/helper/rollup/rules.go:278 +0x17
graphite-clickhouse-1 | github.com/lomik/graphite-clickhouse/render/data.(*conditions).prepareLookup(0xc000708780)
graphite-clickhouse-1 | /go/src/github.com/lomik/graphite-clickhouse/render/data/query.go:297 +0x210
graphite-clickhouse-1 | github.com/lomik/graphite-clickhouse/render/data.(*query).getDataPoints(0xc00019e500, {0x1b55360, 0xc0007a6d20}, 0xc000708780)
graphite-clickhouse-1 | /go/src/github.com/lomik/graphite-clickhouse/render/data/query.go:150 +0xda
graphite-clickhouse-1 | github.com/lomik/graphite-clickhouse/render/data.(*MultiTarget).Fetch.func2(0xc00054d200?)
graphite-clickhouse-1 | /go/src/github.com/lomik/graphite-clickhouse/render/data/multi_target.go:206 +0x70
graphite-clickhouse-1 | created by github.com/lomik/graphite-clickhouse/render/data.(*MultiTarget).Fetch in goroutine 295
graphite-clickhouse-1 | /go/src/github.com/lomik/graphite-clickhouse/render/data/multi_target.go:204 +0x605
graphite-clickhouse-1 | [2025-09-07T07:27:14.189Z] WARN [config] warnings {"enable find cache": {"Key":"type","Type":15,"Integer":0,"String":"mem","Interface":null}}
graphite-clickhouse-1 | [2025-09-07T07:27:14.228Z] ERROR [rollup] rollup rules update failed for table "graphite_ng.graphite" {"error": "json: cannot unmarshal number into Go struct field rollupRulesResponseRecord.data.age of type string"}
graphite-clickhouse panics then.
Can maybe open a pull request in a few days to fix this.
Possible solutions would be to convert the struct to ints https://github.com/go-graphite/graphite-clickhouse/blob/master/helper/rollup/remote.go#L17-L24
or to convert the ints to strings in the select statements.
Metadata
Metadata
Assignees
Labels
No labels