Fix tracing tests by replacing test.com endpoint with httpbin.org (#952)

go-kit · Feb 1, 2020 · 7ea682b · 7ea682b
1 parent 5d467ee
commit 7ea682b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tracing/opencensus/http_test.go b/tracing/opencensus/http_test.go
@@ -23,7 +23,7 @@ func TestHTTPClientTrace(t *testing.T) {
  var (
  err error
  rec = &recordingExporter{}
- rURL, _ = url.Parse("http://test.com/dummy/path")
+ rURL, _ = url.Parse("https://httpbin.org/get")
  )
 
  trace.RegisterExporter(rec)
@@ -72,7 +72,7 @@ func TestHTTPClientTrace(t *testing.T) {
  t.Errorf("incorrect span name, want %s, have %s", want, have)
  }
 
- if want, have := "GET /dummy/path", span.Name; want != have && tr.name == "" {
+ if want, have := "GET /get", span.Name; want != have && tr.name == "" {
  t.Errorf("incorrect span name, want %s, have %s", want, have)
  }
 

diff --git a/tracing/zipkin/http_test.go b/tracing/zipkin/http_test.go
@@ -33,7 +33,7 @@ func TestHTTPClientTracePropagatesParentSpan(t *testing.T) {
 
  tr, _ := zipkin.NewTracer(rec)
 
- rURL, _ := url.Parse("http://test.com")
+ rURL, _ := url.Parse("https://httpbin.org/get")
 
  clientTracer := zipkinkit.HTTPClientTrace(tr)
  ep := kithttp.NewClient(