Some code improvements (#868)

* Simplify some functions. * strings.ToLower comparison changed to strings.EqualFold.
go-kit · May 6, 2019 · fbab14b · fbab14b
1 parent da68e76
commit fbab14b
Show file tree

Hide file tree

Showing 3 changed files with 167 additions and 168 deletions.
diff --git a/auth/jwt/transport.go b/auth/jwt/transport.go
@@ -77,7 +77,7 @@ func ContextToGRPC() grpc.ClientRequestFunc {
 
 func extractTokenFromAuthHeader(val string) (token string, ok bool) {
 	authHeaderParts := strings.Split(val, " ")
-	if len(authHeaderParts) != 2 || strings.ToLower(authHeaderParts[0]) != bearer {
+	if len(authHeaderParts) != 2 || !strings.EqualFold(authHeaderParts[0], bearer) {
 		return "", false
 	}
 

diff --git a/examples/addsvc/thrift/gen-go/addsvc/add_service-remote/add_service-remote.go b/examples/addsvc/thrift/gen-go/addsvc/add_service-remote/add_service-remote.go
diff --git a/metrics/generic/generic_test.go b/metrics/generic/generic_test.go
@@ -20,7 +20,7 @@ func TestCounter(t *testing.T) {
 	if want, have := name, counter.Name; want != have {
 		t.Errorf("Name: want %q, have %q", want, have)
 	}
-	value := func() float64 { return counter.Value() }
+	value := counter.Value
 	if err := teststat.TestCounter(counter, value); err != nil {
 		t.Fatal(err)
 	}
@@ -45,7 +45,7 @@ func TestGauge(t *testing.T) {
 	if want, have := name, gauge.Name; want != have {
 		t.Errorf("Name: want %q, have %q", want, have)
 	}
-	value := func() float64 { return gauge.Value() }
+	value := gauge.Value
 	if err := teststat.TestGauge(gauge, value); err != nil {
 		t.Fatal(err)
 	}