Replace log.Context with log.With/WithPrefix?

[willfaught]

Given the stdlib discussion, is there any interest in replacing log.Context with log.With/WithPrefix?

[ChrisHines]

I plan to post a PR to do it very soon. That will let us evaluate the overall impact. It will probably break a lot of code, but the migration is pretty straight forward. Also, if we're going to do it, now is the time, before we publish v1.0.0.

[peterbourgon]

For the record I think this is a straightforward change and should probably make it into 1.0.0, barring any unforeseen weirdness.

[ChrisHines]

Agreed. My only concern is that unexporting Context somehow cripples a use case that needed to store a *Context, but I don't think we will find that to be the case. I also think that the benefits of this change will turn out to be rather significant from a simplicity point of view. I'll document the pros and cons in the PR which I hope to have up tonight, or by the end of the weekend at the latest.

[willfaught]

Without knowing more about that particular use case for Context, I'm guessing you could still make your own context type if you need one?

…

On Fri, Mar 3, 2017 at 6:34 AM Chris Hines ***@***.***> wrote: Agreed. My only concern is that unexporting Context somehow cripples a use case that needed to store a *Context, but I don't think we will find that to be the case. I also think that the benefits of this change will turn out to be rather significant from a simplicity point of view. I'll document the pros and cons in the PR which I hope to have up tonight, or by the end of the weekend at the latest. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#474 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD5VuGSNGz0I8XUb-ECYmQ6baZ1eu1Iks5riCTxgaJpZM4MQZjb> .

[ChrisHines]

Nope, just forgot to close it. Thanks for the ping.

[ereOn]

@ChrisHines I just deleted my comment as I realized a release was planned for tomorrow and thought this would be solved at that moment. You are welcome !