Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to move from prometheus http (deprecated) to the new one #491

Closed
sergiomss opened this issue Mar 8, 2017 · 2 comments · Fixed by #497
Closed

Request to move from prometheus http (deprecated) to the new one #491

sergiomss opened this issue Mar 8, 2017 · 2 comments · Fixed by #497
Labels
enhancement help wanted newbie friendly

Comments

@sergiomss
Copy link

As it stands on the http.go file in the prometheus/client_golang repository, that file has been deprecated and moved to prom/http directory, with some changes. Quoted from http.go comment section:

It is a partial mirror of promhttp/http.go (to avoid circular import chains) where 
everything HTTP related should live. The functions here are just for avoiding breakage. 
Everything is deprecated.

For this reason, would it be possible to update the prometheus metrics in go-kit to use the new one?
@kavirajk
Copy link
Contributor

kavirajk commented Mar 9, 2017

Can I work on this?

@peterbourgon
Copy link
Member

Please!

kavirajk added a commit to kavirajk/kit that referenced this issue Mar 12, 2017
@kavirajk
Request to move from prometheus http (deprecated) to the promhttp
593cc9a 
fixes go-kit#491
@kavirajk kavirajk mentioned this issue Mar 12, 2017
Merged
yurishkuro pushed a commit to yurishkuro/kit that referenced this issue May 17, 2017
@kavirajk
Request to move from prometheus http (deprecated) to the promhttp
072cd1e 
fixes go-kit#491
jamesgist pushed a commit to jamesgist/kit that referenced this issue Nov 1, 2024
@kavirajk
Request to move from prometheus http (deprecated) to the promhttp
5dc61a3 
fixes go-kit#491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted newbie friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request to move from prometheus http (deprecated) to the promhttp kavirajk/kit
3 participants
@peterbourgon @kavirajk @sergiomss