Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept header available in context? #515

Closed
JeanMertz opened this issue Apr 18, 2017 · 2 comments
Closed

Accept header available in context? #515

JeanMertz opened this issue Apr 18, 2017 · 2 comments

Comments

@JeanMertz
Copy link

I noticed that the PopulateRequestContext function does not transfer the Accept header from the request object to the context.

I'm using a custom ServerBefore function to add this header, but I was somewhat surprised, as the Accept header is something you use a lot when working with APIs that support multiple response formats.

peterbourgon added a commit that referenced this issue Apr 19, 2017
Add the request Accept header to the context,
under the ContextKeyRequestAccept key.

Closes #515.
@peterbourgon
Copy link
Member

Does #516 do what you'd expect?

@JeanMertz
Copy link
Author

It does, thank you for doing the work. I would've added it myself, but I didn't want to put in the "work" before I got some form of acknowledgement that this would be a good addition.

Either way, thank you, and keep up the good work with this project 👍

yurishkuro pushed a commit to yurishkuro/kit that referenced this issue May 17, 2017
Add the request Accept header to the context,
under the ContextKeyRequestAccept key.

Closes go-kit#515.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants