Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD:Consul - On an EOF error continue the loop #786

Closed
kcajmagic opened this issue Nov 5, 2018 · 0 comments
Closed

SD:Consul - On an EOF error continue the loop #786

kcajmagic opened this issue Nov 5, 2018 · 0 comments

Comments

@kcajmagic
Copy link
Contributor

kcajmagic commented Nov 5, 2018

The loop in question

What is happening

In a rare occurrence, an EOF error can be received from the consul agent and new updates will not be received. When logging into the instance, no traffic from go-kit to the consul agent is observed. I believe this is from the loop exiting. The consul agent logged an error rpc error making call: EOF and the application had the error Unexpected response code: 500 (rpc error making call: EOF)

I have been unable to consistently reproduce the issue. However, the app(go-kit) and consul seem to be happy, even though there is an inconsistency in the sd instances.

What is expected

If an EOF error is received do an exponential back like other errors

This way when an EOF error occurs and both the consul agent and the app are alive, both will continue to work as expected.

A solution (the one on the top of my head)

Have a custom error for the quitc, and use this error to exit the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants