Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Consul SD loop exiting on EOF #788

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Fix Consul SD loop exiting on EOF #788

merged 3 commits into from
Nov 7, 2018

Conversation

kcajmagic
Copy link
Contributor

Closes #786 by having a custom error errStopped for when Stop() is called.

@kcajmagic kcajmagic mentioned this pull request Nov 6, 2018
Closed
@peterbourgon
Copy link
Member

Thanks! Can you rebase? It should fix the tests.

@peterbourgon peterbourgon merged commit 33fad1e into go-kit:master Nov 7, 2018
@kcajmagic kcajmagic deleted the fixConsulLoop branch July 17, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcajmagic @peterbourgon