Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RequestSampler in zipkin server middleware #812

Closed
jcchavezs opened this issue Dec 14, 2018 · 1 comment
Closed

Support RequestSampler in zipkin server middleware #812

jcchavezs opened this issue Dec 14, 2018 · 1 comment

Comments

@jcchavezs
Copy link
Contributor

jcchavezs commented Dec 14, 2018 •
edited
Loading

zipkin-go includes an option missing in this server middleware, RequestSampler which allows to change the sampling decision based on the request. This is specially useful when you want to sample requests coming from async operations (that often don't include tracing propagation) and in general to give more granularity to the sampling.

We are lacking that option in this server middleware, should I open a PR for that?

Ping @basvanbeek
@basvanbeek
Copy link
Member

Yes that would be a good addition, especially for frontend services.

jcchavezs added a commit to jcchavezs/kit that referenced this issue Dec 14, 2018
@jcchavezs
[go-kit#812] adds request sampler into zipkin tracing.
765ff6c
@jcchavezs jcchavezs mentioned this issue Dec 14, 2018
Merged
jcchavezs added a commit to jcchavezs/kit that referenced this issue Jan 1, 2019
@jcchavezs
[go-kit#812] swaps tested conditions
272f7b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcchavezs @basvanbeek