Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture newlines in log stdlib #1041

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 29, 2020

Capture newlines in the stdlib adapter messages. Avoids cutting off
multi-line log messages.

See: prometheus/node_exporter#1886

Signed-off-by: Ben Kochie superq@gmail.com

log/stdlib_test.go Outdated Show resolved Hide resolved
Capture newlines in the stdlib adapter messages. Avoids cutting off
multi-line log messages.

See: prometheus/node_exporter#1886

Signed-off-by: Ben Kochie <superq@gmail.com>
@peterbourgon
Copy link
Member

Thanks!

@peterbourgon peterbourgon merged commit 0ca2279 into go-kit:master Nov 30, 2020
@SuperQ SuperQ deleted the stdout_newlines branch November 30, 2020 02:42
@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants