Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1124

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

sagikazarmark
Copy link
Contributor

This PR updates some more dependencies (released since the last one or ones that I missed earlier) before the 0.11.0 release.

@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 28, 2021
@peterbourgon
Copy link
Member

How do we keep "update dependencies" PRs to an absolute minimum? I really really do not want to field an infinite series of "update deps" PRs until my death 😉 As part of the release seems OK, can we stick to that policy?

@sagikazarmark
Copy link
Contributor Author

I think that's fair. AWS SDK for example is released almost every day, we probably shouldn't update it every day. 😉

We could automate dependency updates using dependabot: it automatically updates dependencies in the form of PRs.

One thing that would help reducing dependency updates is reducing dependencies. 🙂 Particularly the sd and metrics packages are quite heavy.

But until then, updating dependencies before releases is fine IMO.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark merged commit 2216160 into go-kit:master Jun 30, 2021
@sagikazarmark sagikazarmark deleted the update-dependencies branch June 30, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants