-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue forms #1166
Merged
Merged
Issue forms #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
peterbourgon
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, didn't know about this. Nice!
Co-authored-by: Peter Bourgon <peterbourgon@users.noreply.github.com>
@peterbourgon apparently contact links don't work without an about text. :\ What would you like me to do? |
Dumb. Just put them back I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates a couple other options for issues provided by GitHub:
An alternative to the markdown issue templates is using issue forms. It's a nice way to make bug reports more sophisticated (eg. make sure to include a version field).
This PR converts the current markdown templates to issue forms. Preview:
It also adds a couple links to the issue opening page offering additional help: https://github.com/sagikazarmark/kit/blob/issue-forms/.github/ISSUE_TEMPLATE/config.yml
TBH, issue forms is not necessarily better for the current templates, because they are quite simple.
A couple examples from other projects: