Fixed overwrite global tags in Influx adapter #404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I found that overwrites global tags in
mergeTags
in Influx adapter of metrics package. Example,Result
As you can see tags from the first counter appear in the second. I think that this is wrong. Map
tags map[string]string
is the root cause of the error, it is passed by pointer and each time frays from other counters/gauges/histograms.Please see my PL.