Use variadic function to pass parameters instead of Config struct #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using function to pass optional params makes the API more consistent with the rest of go-kit packages. For go-kit#427
| // will be squelched, and ErrNotAllowed returned. | ||
| Allowed []string | ||
| // New wraps the logger and implements level checking. See the commentary on the | ||
| // Option functions for a detailed description of how to configure levels. |
There was a problem hiding this comment.
Would you mind adding an extra sentence of commentary describing the default behavior with no options set?
| level.Allowed(level.AllowWarnAndAbove()), | ||
| level.ErrNotAllowed(myError), | ||
| } | ||
| logger := level.New(log.NewNopLogger(), opts...) |
There was a problem hiding this comment.
Any reason not to inline these? I'm not fussed, just curious.
There was a problem hiding this comment.
No specific reason. I usually prefer to create a slice when I have multiple options because it looks more organized, especially if there's a chance the list of options will grow in the future.
I'd be glad to change it if you have the opposite preference.
|
Brilliant, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using function to pass optional params makes the API more consistent
with the rest of go-kit packages.
For #427
Following up on discussion in #427 (comment)
I thought it was important to get this change in before #449 and ultimately 1.0.0 to avoid making breaking changes in a stable API.