Use per request context as provided by net/http. (deprecates server wide context) #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t context provided by net/http
|
+1 I am not even sure there was a static context in the api, since context is a request-scoped concept. |
|
LGTM! Merge at your leisure. |
|
See: https://golang.org/pkg/context/
With both HTTP and gRPC transports providing a per request generated Context server side we should really use those. Is there anything you were doing with context values before passing them to |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Use per request context as provided by *http.Request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since go 1.7 we have per request context available. This eliminates the need for server wide scoped context. Since this is also our now lowest supported version we can move away from the old implementation.
This PR removes using the server wide context inside the ServeHTTP handler in favor of the one provided by *http.Request.
Examples and tests have been updated to reflect the change too.