Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated thrift to latest Go library adding support for context #585

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

basvanbeek
Copy link
Member

In our addsvc example we supply a thrift transport which due to the api change in the Thrift Go library was broken.

This PR adds the support for context.Context as found in the latest Thrift Go library.

@basvanbeek
Copy link
Member Author

travis has an unrelated build failure:

The command "go test -race -v ./..." exited with 0.
0.01s$ ./coveralls.bash
/home/travis/gopath/bin/gover
/home/travis/gopath/bin/goveralls
COVERALLS_TOKEN not set
The command "./coveralls.bash" exited with 1.

@peterbourgon
Copy link
Member

What, that's garbage, the env var is clearly set in Travis..... argh

@peterbourgon
Copy link
Member

We do not provide [repository environment variables] to untrusted builds, triggered by pull requests from another repository.

https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

😠

@peterbourgon
Copy link
Member

@basvanbeek Sorry, can you rebase on master?

@peterbourgon
Copy link
Member

Leeroy Jenkins

@peterbourgon peterbourgon merged commit 872ceff into go-kit:master Jul 26, 2017
jamesgist pushed a commit to jamesgist/kit that referenced this pull request Nov 1, 2024
updated thrift to latest Go library adding support for context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants