Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thrift, if it needs fixing #678

Merged
merged 2 commits into from
Mar 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion examples/addsvc/thrift/compile.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
#!/usr/bin/env sh

# See also https://thrift.apache.org/tutorial/go
# See also https://thrift.apache.org/tutorial/go.
#
# An old version can be obtained via `brew install thrift`.
# For the latest, here's the annoying dance:
#
# brew install automake bison pkg-config openssl
# ln -s /usr/local/opt/openssl/include/openssl /usr/local/include # if it isn't already
# git clone git@github.com:apache/thrift
# ./bootstrap.sh
# bash
# export PATH=/usr/local/Cellar/bison/*/bin:$PATH
# ./configure ./configure --without-qt4 --without-qt5 --without-c_glib --without-csharp --without-java --without-erlang --without-nodejs --without-lua --without-python --without-perl --without-php --without-php_extension --without-dart --without-ruby --without-haskell --without-rs --without-cl --without-haxe --without-dotnetcore --without-d
# make
# sudo make install

thrift -r --gen "go:package_prefix=github.com/go-kit/kit/examples/addsvc/thrift/gen-go/,thrift_import=github.com/apache/thrift/lib/go/thrift" addsvc.thrift

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/addsvc/thrift/gen-go/addsvc/addsvc-consts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 13 additions & 12 deletions examples/addsvc/thrift/gen-go/addsvc/addsvc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.