Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a TODO context #857

Merged
merged 1 commit into from
Apr 16, 2019
Merged

use a TODO context #857

merged 1 commit into from
Apr 16, 2019

Conversation

h8liu
Copy link
Contributor

@h8liu h8liu commented Apr 7, 2019

No description provided.

@h8liu h8liu changed the title fix #856 use a TODO context Apr 7, 2019
@peterbourgon
Copy link
Member 

=== RUN   TestSend
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x7f0865]

goroutine 11 [running]:
net/http.(*Request).WithContext(...)
	/usr/local/go/src/net/http/request.go:353
github.com/aws/aws-sdk-go-v2/aws.setRequestContext(...)
	/home/build/go/src/github.com/aws/aws-sdk-go-v2/aws/request_context.go:11

Doesn't work.

@h8liu
Copy link
Contributor Author

h8liu commented Apr 12, 2019

please take a look.

@peterbourgon peterbourgon mentioned this pull request Apr 12, 2019
Closed
@h8liu
Copy link
Contributor Author

h8liu commented Apr 13, 2019

not sure why circleci failed this time.

@peterbourgon peterbourgon merged commit 22a2d43 into go-kit:master Apr 16, 2019
@peterbourgon
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h8liu @peterbourgon