-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use batch values API for CloudWatch PutMetric data call #960
Conversation
|
Yup, sorry. |
@peterbourgon hey, fixing the tests took some effort and changes. |
@cam-stitt This is your package :D Feedback? @trane9991 Did you see package cloudwatch2? Should this be ported there, too? |
hmmm... I see that cloudwatch2 uses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the implementation, but I think we can just tidy it a little and always use the batch request.
}) | ||
} | ||
|
||
if len(values) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move this above the datum initialization to save an alloc, but not a big deal.
Nice, thanks! |
Some time ago, AWS introduced the way to publish a batch of metric values in one call.
So there is no point in sending
last(values)
if we could send the whole batch.This PR implements the sending of values batch,