Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to use specific logrus level in the adaptor #962

Merged
merged 7 commits into from
Mar 10, 2020
Merged

allow to use specific logrus level in the adaptor #962

merged 7 commits into from
Mar 10, 2020

Conversation

taraspos
Copy link
Contributor

No description provided.

ChrisHines
ChrisHines requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@ChrisHines ChrisHines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Happy to add this feature, but would like it implemented a bit differently, see inline comment below.

ChrisHines
ChrisHines requested changes Feb 21, 2020
View reviewed changes
log/logrus/logrus_logger.go Outdated Show resolved Hide resolved
ChrisHines
ChrisHines requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@ChrisHines ChrisHines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's getting closer. There are a couple more tweaks to make, though.

log/logrus/logrus_logger.go Outdated Show resolved Hide resolved
ChrisHines
ChrisHines requested changes Feb 24, 2020
View reviewed changes
Copy link
Member

@ChrisHines ChrisHines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates.

Next, it would be nice to add something to the unit tests to verify the new feature works as intended.

Also, see my suggestion on the docs for WithLevel below.

log/logrus/logrus_logger.go Outdated Show resolved Hide resolved
ChrisHines
ChrisHines requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@ChrisHines ChrisHines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this. It is looking pretty good, I just have one comment on the new test.

log/logrus/logrus_logger_test.go Outdated Show resolved Hide resolved
@taraspos taraspos requested a review from ChrisHines March 9, 2020 21:37
@taraspos
Copy link
Contributor Author

taraspos commented Mar 9, 2020

Sorry for the delay. Fixed!

@ChrisHines
Copy link
Member

LGTM, thanks for the contribution!

@ChrisHines ChrisHines merged commit ad60314 into go-kit:master Mar 10, 2020
@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbourgon peterbourgon peterbourgon left review comments

@ChrisHines ChrisHines ChrisHines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@taraspos @ChrisHines @peterbourgon @sagikazarmark