Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version to JSON-RPC client request #990

Merged

Conversation

shirolimit
Copy link
Contributor

This tiny PR addresses the issue with JSON-RPC client: #986

For some reason current implementation leaves jsonrpc field empty and there is no easy way to change it (there is a workaround with ClientBefore which is not a good option). Some server implementations require this field to be 2.0.

According to the documentation go-kit implementation only supports v2.0, that is why I don't think this parameter should be configurable.

@peterbourgon
Copy link
Member

Thanks!

@peterbourgon peterbourgon merged commit b1d0a5d into go-kit:master Jun 15, 2020
@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants