Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc‘s secure discovery #1270

Merged
merged 6 commits into from
Jul 28, 2021
Merged

grpc‘s secure discovery #1270

merged 6 commits into from
Jul 28, 2021

Conversation

daemon365
Copy link
Member

根据 grpc dial’s insecure 选择对应的gprc链接 (isSecure参数)

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1270 (ecb901a) into main (352d6c8) will increase coverage by 0.09%.
The diff coverage is 51.85%.

❗ Current head ecb901a differs from pull request most recent head 24c0f33. Consider uploading reports for the commit 24c0f33 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   51.04%   51.13%   +0.09%     
==========================================
  Files          52       53       +1     
  Lines        2541     2554      +13     
==========================================
+ Hits         1297     1306       +9     
- Misses       1098     1103       +5     
+ Partials      146      145       -1     
Impacted Files Coverage Δ
transport/grpc/client.go 27.14% <0.00%> (ø)
transport/grpc/resolver/discovery/builder.go 0.00% <0.00%> (ø)
transport/grpc/resolver/discovery/resolver.go 42.30% <50.00%> (-0.83%) ⬇️
internal/endpoint/endpoint.go 100.00% <100.00%> (ø)
transport/grpc/server.go 35.00% <100.00%> (ø)
transport/http/server.go 54.78% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352d6c8...24c0f33. Read the comment docs.

transport/grpc/resolver/discovery/builder.go Outdated Show resolved Hide resolved
transport/grpc/server.go Outdated Show resolved Hide resolved
@daemon365
Copy link
Member Author

@tonybase 我把这个client isSecure 换成 insecure 应该好理解一些 这个参数是grpc.Dial时的insecure 参数 代表是不是不安全的连接 discovery更新node的时候需要知道 自己是不是安全的Dial

@tonybase tonybase merged commit 8f4e78b into go-kratos:main Jul 28, 2021
elvizlai pushed a commit to elvizlai/kratos that referenced this pull request Aug 2, 2021
* add gprc secure discovery

* add http insecure filter
@daemon365 daemon365 deleted the dev-grpcSecure branch August 2, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants