Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endpoint): add endpoint parser #1273

Merged
merged 3 commits into from
Jul 29, 2021
Merged

feat(endpoint): add endpoint parser #1273

merged 3 commits into from
Jul 29, 2021

Conversation

tonybase
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #1273 (71f9a0c) into main (8f4e78b) will increase coverage by 0.18%.
The diff coverage is 41.93%.

❗ Current head 71f9a0c differs from pull request most recent head 3e73375. Consider uploading reports for the commit 3e73375 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   51.09%   51.27%   +0.18%     
==========================================
  Files          53       53              
  Lines        2556     2545      -11     
==========================================
- Hits         1306     1305       -1     
+ Misses       1105     1097       -8     
+ Partials      145      143       -2     
Impacted Files Coverage Δ
transport/grpc/server.go 35.00% <ø> (ø)
internal/endpoint/endpoint.go 52.63% <18.18%> (-47.37%) ⬇️
transport/http/client.go 54.09% <42.85%> (-0.05%) ⬇️
transport/http/resolver.go 14.86% <80.00%> (+2.22%) ⬆️
transport/grpc/resolver/discovery/resolver.go 46.51% <100.00%> (+4.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f4e78b...3e73375. Read the comment docs.

@tonybase tonybase added the enhancement New feature or request label Jul 28, 2021
@tonybase tonybase merged commit bc35f20 into main Jul 29, 2021
@tonybase tonybase deleted the tls-endpoint branch July 29, 2021 02:11
elvizlai pushed a commit to elvizlai/kratos that referenced this pull request Aug 2, 2021
* feat(endpoint): add endpoint parser

* fix parseTarget ut

* fix insecure testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants