Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/pgh): add processing when generating HTTP code #1306

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Conversation

shenqidebaozi
Copy link
Member

For interfaces that require body, such as POST、PUT、PATCH, if no body is declared, the warning log is printed

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #1306 (eb54115) into main (e5ae8dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1306   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files          56       56           
  Lines        2661     2661           
=======================================
  Hits         1441     1441           
  Misses       1078     1078           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ae8dc...eb54115. Read the comment docs.

@shenqidebaozi shenqidebaozi changed the title feat: add processing when generating HTTP code feat(cmd/pgh): add processing when generating HTTP code Aug 6, 2021
@shenqidebaozi
Copy link
Member Author

In addition, body binding should not be allowed in delete requests

Copy link
Member

@Windfarer Windfarer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@longXboy longXboy merged commit ff78611 into main Aug 9, 2021
@longXboy longXboy deleted the feat/cmd-http branch August 9, 2021 02:28
zouyx pushed a commit to zouyx/kratos that referenced this pull request Aug 24, 2021
* feat: add processing when generating HTTP code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants