Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append config watchers when watch source #1320

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

byteneco
Copy link
Contributor

Description (what this PR does / why we need it):

add watchers to config when load.

Which issue(s) this PR fixes:

fixes #1318

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2021

Codecov Report

Merging #1320 (19b5f9c) into main (6ae2e87) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 19b5f9c differs from pull request most recent head 357d1f4. Consider uploading reports for the commit 357d1f4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   54.34%   54.35%   +0.01%     
==========================================
  Files          56       56              
  Lines        2672     2673       +1     
==========================================
+ Hits         1452     1453       +1     
  Misses       1078     1078              
  Partials      142      142              
Impacted Files Coverage Δ
config/config.go 56.94% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae2e87...357d1f4. Read the comment docs.

@byteneco
Copy link
Contributor Author

#1319
this pr will fix this

@byteneco byteneco closed this Aug 12, 2021
@byteneco byteneco deleted the fix/config-watcher branch August 12, 2021 03:33
@daemon365
Copy link
Member

想了下 我那个不适配现有的etcd等 在这讨论下 怎么改吧

@byteneco byteneco restored the fix/config-watcher branch August 12, 2021 03:49
@byteneco byteneco reopened this Aug 12, 2021
@byteneco
Copy link
Contributor Author

可以返回特定的Error来停止死循环吗

@tonybase tonybase merged commit 39a36b4 into go-kratos:main Aug 12, 2021
zouyx pushed a commit to zouyx/kratos that referenced this pull request Aug 24, 2021
Co-authored-by: sukkids <ehekirahoshi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]Config包Load时没有设置source的watcher
4 participants