fix:config groutine(watch) leak #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
- Coverage 60.49% 60.30% -0.20%
==========================================
Files 59 59
Lines 2739 2751 +12
==========================================
+ Hits 1657 1659 +2
- Misses 937 946 +9
- Partials 145 146 +1
Continue to review full report at Codecov.
|
daemon365
changed the title
longXboy
reviewed
Aug 13, 2021
config/config.go
Outdated
| @@ -65,6 +66,10 @@ func New(opts ...Option) Config { | |||
| func (c *config) watch(w Watcher) { | |||
| for { | |||
| kvs, err := w.Next() | |||
| if err == context.Canceled { | |||
tonybase
approved these changes
Aug 13, 2021
zouyx
pushed a commit
to zouyx/kratos
that referenced
this pull request
Aug 24, 2021
* fix:config goroutine(watch) Leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes:
fixes #
Other special notes for reviewer:
code :
kratos/config/config.go
Line 111 in 55cf830