-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): support discovery registry center #1480
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 66.65% 66.76% +0.10%
==========================================
Files 66 66
Lines 3038 3033 -5
==========================================
Hits 2025 2025
+ Misses 841 836 -5
Partials 172 172
Continue to review full report at Codecov.
|
feat #1472 |
review plz ~ |
Why not quote the original bilibili/discovery SDK and wrap it to implement kratos interface instead of copying the code? |
|
LGTM |
Description (what this PR does / why we need it):
discovery
registry centerWhich issue(s) this PR fixes (resolves / be part of):
resolves #1472
Other special notes for reviewer:
I need some time to refactor code style, any advices and code review can help this work, thanks ~