Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): http client support service discovery in Do #1563

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

letian0805
Copy link
Contributor

@letian0805 letian0805 commented Oct 18, 2021

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes # #1562

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1563 (5d8481e) into main (143dc58) will decrease coverage by 7.56%.
The diff coverage is 31.81%.

❗ Current head 5d8481e differs from pull request most recent head 0a54572. Consider uploading reports for the commit 0a54572 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1563      +/-   ##
==========================================
- Coverage   81.61%   74.04%   -7.57%     
==========================================
  Files          78       69       -9     
  Lines        3389     3129     -260     
==========================================
- Hits         2766     2317     -449     
- Misses        424      607     +183     
- Partials      199      205       +6     
Impacted Files Coverage Δ
transport/http/client.go 66.84% <31.81%> (-10.93%) ⬇️
transport/http/binding/bind.go 0.00% <0.00%> (-100.00%) ⬇️
transport/grpc/balancer.go 25.49% <0.00%> (-66.67%) ⬇️
log/level.go 37.03% <0.00%> (-62.97%) ⬇️
transport/http/context.go 30.95% <0.00%> (-60.72%) ⬇️
transport/http/router.go 66.66% <0.00%> (-28.58%) ⬇️
transport/http/binding/encode.go 58.97% <0.00%> (-20.52%) ⬇️
log/helper.go 61.22% <0.00%> (-20.41%) ⬇️
log/std.go 80.00% <0.00%> (-20.00%) ⬇️
log/value.go 81.48% <0.00%> (-18.52%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143dc58...0a54572. Read the comment docs.

@letian0805 letian0805 changed the title feat(http): add Target method for http client feat(http): http client support service discovery in Do Oct 18, 2021
longXboy
longXboy previously approved these changes Oct 20, 2021
longXboy
longXboy previously approved these changes Oct 26, 2021
tonybase
tonybase previously approved these changes Oct 28, 2021
transport/http/client.go Outdated Show resolved Hide resolved
@tonybase tonybase merged commit 32272fe into go-kratos:main Nov 5, 2021
@letian0805 letian0805 deleted the feat/http_client_request branch November 8, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants