Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:modify annotation and wrong words #1615

Merged
merged 2 commits into from
Nov 8, 2021
Merged

fix:modify annotation and wrong words #1615

merged 2 commits into from
Nov 8, 2021

Conversation

daemon365
Copy link
Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #1615 (01dabae) into main (988c231) will increase coverage by 0.14%.
The diff coverage is 66.66%.

❗ Current head 01dabae differs from pull request most recent head b924b99. Consider uploading reports for the commit b924b99 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
+ Coverage   81.41%   81.56%   +0.14%     
==========================================
  Files          78       78              
  Lines        3412     3412              
==========================================
+ Hits         2778     2783       +5     
+ Misses        434      430       -4     
+ Partials      200      199       -1     
Impacted Files Coverage Δ
selector/default_node.go 100.00% <ø> (ø)
selector/default_selector.go 88.00% <ø> (ø)
selector/filter/version.go 100.00% <ø> (ø)
selector/p2c/p2c.go 100.00% <ø> (ø)
selector/random/random.go 100.00% <ø> (ø)
selector/wrr/wrr.go 100.00% <ø> (ø)
selector/node/ewma/node.go 87.09% <66.66%> (+3.22%) ⬆️
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988c231...b924b99. Read the comment docs.

Copy link
Member

@ymh199478 ymh199478 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit fcd9351 into main Nov 8, 2021
@tonybase tonybase deleted the fix/wrongWord branch November 8, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants