refactor: move from io/ioutil to io and os packages #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1633 +/- ##
==========================================
+ Coverage 81.26% 81.31% +0.05%
==========================================
Files 78 78
Lines 3426 3426
==========================================
+ Hits 2784 2786 +2
+ Misses 442 440 -2
Partials 200 200
Continue to review full report at Codecov.
|
Windfarer
approved these changes
Nov 16, 2021
kiripeng214
added a commit
to kiripeng214/kratos
that referenced
this pull request
Nov 16, 2021
refactor: move from io/ioutil to io and os packages (go-kratos#1633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
The
io/ioutilpackage has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). This PR replaces the existingio/ioutilfunctions with their new definitions inioandospackages.Which issue(s) this PR fixes (resolves / be part of):
Other special notes for reviewer: