Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nacos): call unsubscribe when watching is stopped #1697

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

shenqidebaozi
Copy link
Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #1697 (2bc9858) into main (7aa9f35) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 2bc9858 differs from pull request most recent head 95546bd. Consider uploading reports for the commit 95546bd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   81.17%   81.11%   -0.06%     
==========================================
  Files          78       78              
  Lines        3431     3431              
==========================================
- Hits         2785     2783       -2     
- Misses        443      445       +2     
  Partials      203      203              
Impacted Files Coverage Δ
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa9f35...95546bd. Read the comment docs.

@shenqidebaozi shenqidebaozi merged commit 32158bc into main Dec 17, 2021
@shenqidebaozi shenqidebaozi deleted the fix/nacos branch December 17, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] kratos配合nacos使用grpc client通过Discovery连接服务器后, 未取消监听?
4 participants