Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: perhaps MISSING #1779

Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix: perhaps MISSING #1779

merged 1 commit into from
Jan 20, 2022

Conversation

shengwudiyi
Copy link
Contributor

fix for unexpected placeholders due to escaping

sample:

msg := `values=%7B%22g`
err := errors.BadRequest("x-reason", msg)

fmt.Println(err.Message == msg) // false
fmt.Println(err.Message)        // values=%!B(MISSING)%!g(MISSING)

Change-Id: If09d5e65ea61f7fbf569b3938db10241f32bb64d
@codecov-commenter
Copy link

Codecov Report

Merging #1779 (25e43a8) into main (f050b07) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 25e43a8 differs from pull request most recent head 5c0afc4. Consider uploading reports for the commit 5c0afc4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
- Coverage   80.79%   80.74%   -0.06%     
==========================================
  Files          80       80              
  Lines        3557     3557              
==========================================
- Hits         2874     2872       -2     
- Misses        477      479       +2     
  Partials      206      206              
Impacted Files Coverage Δ
errors/types.go 100.00% <100.00%> (ø)
internal/context/context.go 97.01% <0.00%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f050b07...5c0afc4. Read the comment docs.

@tonybase tonybase merged commit c250958 into go-kratos:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants