Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): optimize typos of swagger/server #1862

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

kwanhur
Copy link
Contributor

@kwanhur kwanhur commented Mar 5, 2022

Description (what this PR does / why we need it):

  • remove redundant import reply
  • not receive unused parameter ctx in SayHello function
  • fix local variable log conflict with imported package

Which issue(s) this PR fixes (resolves / be part of):

fixes #

Other special notes for reviewer:

* remove redundant import reply
* not receive unused parameter ctx in SayHello function
* fix local variable log conflict with imported package

Signed-off-by: kwanhur <huang_hua2012@163.com>
Copy link
Contributor

@Cluas Cluas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #1862 (b6ebe24) into main (ed6ab7c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   80.78%   80.84%   +0.05%     
==========================================
  Files          80       80              
  Lines        3565     3565              
==========================================
+ Hits         2880     2882       +2     
+ Misses        479      477       -2     
  Partials      206      206              
Impacted Files Coverage Δ
internal/context/context.go 100.00% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6ab7c...b6ebe24. Read the comment docs.

@shenqidebaozi shenqidebaozi merged commit 79057d4 into go-kratos:main Mar 7, 2022
@kwanhur kwanhur deleted the typo-alias branch March 7, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants