Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kratos command error on windows #1884

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

letian0805
Copy link
Contributor

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

fixes #1883

Other special notes for reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #1884 (84d75f7) into main (c550a88) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1884   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          80       80           
  Lines        3568     3568           
=======================================
  Hits         2883     2883           
  Misses        478      478           
  Partials      207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c550a88...84d75f7. Read the comment docs.

@letian0805 letian0805 changed the title fix kratos command error on windows fix(cmd/kratos):kratos command error on windows Mar 17, 2022
@letian0805 letian0805 changed the title fix(cmd/kratos):kratos command error on windows fix: kratos command error on windows Mar 17, 2022
@shenqidebaozi
Copy link
Member

乐天老师可以附带一下单元测试吗?

@letian0805
Copy link
Contributor Author

乐天老师可以附带一下单元测试吗?

加上了

Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi merged commit d373c51 into go-kratos:main Mar 17, 2022
@letian0805 letian0805 deleted the fix/kratos_command branch March 17, 2022 10:44
tonybase pushed a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kratos command on windows report error when repo url contains a colon
4 participants