Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): add endpoint option for server #2904

Merged

Conversation

youzhixiaomutou
Copy link
Contributor

Description (what this PR does / why we need it):

transport/server.go exposes an Endpoint() option that allows to specify the endpoint when defining the server, instead of manually specifying it for each server when creating a new app.

endpoint *url.URL

Which issue(s) this PR fixes (resolves / be part of):

fixes/resolves #2902

Other special notes for the reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #2904 (163f646) into main (db2a565) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head 163f646 differs from pull request most recent head ba36d3f. Consider uploading reports for the commit ba36d3f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
- Coverage   84.50%   84.38%   -0.13%     
==========================================
  Files          88       88              
  Lines        3970     3976       +6     
==========================================
  Hits         3355     3355              
- Misses        438      445       +7     
+ Partials      177      176       -1     
Impacted Files Coverage Δ
transport/grpc/server.go 81.37% <0.00%> (-2.47%) ⬇️
transport/http/server.go 73.07% <0.00%> (-1.44%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonybase tonybase merged commit bffc1a0 into go-kratos:main Jul 6, 2023
@youzhixiaomutou youzhixiaomutou deleted the feat/add_transport_endpoint_options branch August 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants