-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(log): WithContext()
changed the ctx field of the parent log.Filter
#3069
Conversation
Do we need to determine if |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3069 +/- ##
==========================================
+ Coverage 84.32% 84.33% +0.01%
==========================================
Files 88 88
Lines 3993 3984 -9
==========================================
- Hits 3367 3360 -7
Misses 449 449
+ Partials 177 175 -2 ☔ View full report in Codecov by Sentry. |
I have added a UT for this. About |
The submitted fix appears to have data race issues |
The data race problem was introduced by #2869. |
Description (what this PR does / why we need it):
Fix the concurrent problem of
log.WithContext()
function.Which issue(s) this PR fixes (resolves / be part of):
Fix #3061
Other special notes for the reviewers: