Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware): adding sentry as errortracker #3122

Merged
merged 19 commits into from
Jan 18, 2024
Merged

feat(middleware): adding sentry as errortracker #3122

merged 19 commits into from
Jan 18, 2024

Conversation

Windfarer
Copy link
Member

Description (what this PR does / why we need it):

add sentry middleware for error tracking

Which issue(s) this PR fixes (resolves / be part of):

  1. move https://github.com/go-kratos/sentry into the main repo
  2. bump the go-sentry version
  3. refactoring attributes naming
  4. add tags options

Other special notes for the reviewers:

The documents should be add to go-kratos.dev and the origin repo https://github.com/go-kratos/sentry should be set to archived

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856bc9a) 84.43% compared to head (1fc496c) 84.69%.
Report is 4 commits behind head on main.

❗ Current head 1fc496c differs from pull request most recent head 56fca9a. Consider uploading reports for the commit 56fca9a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
+ Coverage   84.43%   84.69%   +0.26%     
==========================================
  Files          88       88              
  Lines        3983     3986       +3     
==========================================
+ Hits         3363     3376      +13     
+ Misses        443      438       -5     
+ Partials      177      172       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenqidebaozi
Copy link
Member

Are you ready to merge?

@shenqidebaozi
Copy link
Member

@Windfarer
Copy link
Member Author

@shenqidebaozi ready for review

@dosubot dosubot bot added the LGTM label Jan 5, 2024
@Windfarer Windfarer merged commit 9860d59 into main Jan 18, 2024
67 checks passed
@Windfarer Windfarer deleted the sentry branch January 18, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants