Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix consul heartbeat 404 error #3147

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

lawlielt
Copy link
Contributor

@lawlielt lawlielt commented Jan 4, 2024

Description (what this PR does / why we need it):

this is will happen when heartbeat start after deregister, some error like below:

'[Consul] update ttl heartbeat to consul failed! err=Unexpected response code: 404 (Unknown check ID "xxxxxx". Ensure that the check ID is passed, not the check name.)

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

this is will happen when heartbeat start after deregister
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 4, 2024
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the LGTM label Jan 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856bc9a) 84.43% compared to head (d251d6c) 84.69%.
Report is 1 commits behind head on main.

❗ Current head d251d6c differs from pull request most recent head 6a19992. Consider uploading reports for the commit 6a19992 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   84.43%   84.69%   +0.26%     
==========================================
  Files          88       88              
  Lines        3983     3986       +3     
==========================================
+ Hits         3363     3376      +13     
+ Misses        443      438       -5     
+ Partials      177      172       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenqidebaozi shenqidebaozi merged commit 4cabcaa into go-kratos:main Jan 5, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants