Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport/http): add unwrap method for returning underlying response writer #3265

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Mar 22, 2024

Description (what this PR does / why we need it):

Add an Unwrap method for returning underlying response writer.

Which issue(s) this PR fixes (resolves / be part of):

resolves #3253

Other special notes for the reviewers:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (1fdaabb) to head (1d9b5a4).

❗ Current head 1d9b5a4 differs from pull request most recent head 7fc0bc5. Consider uploading reports for the commit 7fc0bc5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
+ Coverage   81.59%   81.64%   +0.05%     
==========================================
  Files          91       91              
  Lines        4167     4168       +1     
==========================================
+ Hits         3400     3403       +3     
+ Misses        589      587       -2     
  Partials      178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the LGTM label Mar 22, 2024
@shenqidebaozi shenqidebaozi merged commit 26d7d5f into go-kratos:main Mar 22, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Unwrap to custom response writer.
3 participants