Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contrib/registry/nacos): Abnormal blocking of the Subscribe and Next methods. #3320

Merged
merged 2 commits into from
May 16, 2024
Merged

fix(contrib/registry/nacos): Abnormal blocking of the Subscribe and Next methods. #3320

merged 2 commits into from
May 16, 2024

Commits on May 10, 2024

  1. fix(contrib/registry/nacos):Abnormal blocking of the Subscribe and Ne… 

    …xt methods.

This submission can solve the channel blocking problem during service discovery, as well as the channel message missing problem when the GRPC idle state changes.

The first scenario is when both the configuration center and registration center are initialized at the same time during service startup, and the SubscribeCallback method will be triggered twice, throwing the error "over time discovering the creation of observers", resulting in a discovery failure. The second scenario occurs after NotLoadCacheAtStart: true. When grpc exits the idle state, calling newWatcher again will not trigger the SubscribeCallback method, causing the Next function to be blocked and the service to be unable to communicate.
    @guoquanwei
    guoquanwei authored May 10, 2024
    Configuration menu
    Copy the full SHA
    ae36077 View commit details
    Browse the repository at this point in the history

  2. Another implementation, the effect remains unchanged

    @guoquanwei
    guoquanwei authored May 10, 2024
    Configuration menu
    Copy the full SHA
    b1aa0da View commit details
    Browse the repository at this point in the history