refactor: lock when to call GetLastError since it might be in communi…

…cation
go-ldap · Jun 22, 2023 · 9de41ce · 9de41ce
1 parent 2f623f0
commit 9de41ce
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/conn.go b/conn.go
@@ -327,6 +327,8 @@ func (l *Conn) nextMessageID() int64 {
 // GetLastError returns the last recorded error from goroutines like processMessages and reader.
 // Only the last recorded error will be returned.
 func (l *Conn) GetLastError() error {
+	l.messageMutex.Lock()
+	defer l.messageMutex.Unlock()
 	return l.err
 }
 

diff --git a/v3/conn.go b/v3/conn.go
@@ -327,6 +327,8 @@ func (l *Conn) nextMessageID() int64 {
 // GetLastError returns the last recorded error from goroutines like processMessages and reader.
 // // Only the last recorded error will be returned.
 func (l *Conn) GetLastError() error {
+	l.messageMutex.Lock()
+	defer l.messageMutex.Unlock()
 	return l.err
 }